Relax activesupport/activemodel upper bound to allow Rails 8 - #51
Open
oartb wants to merge 1 commit into
Open
Conversation
xdr caps both at < 8.0 with no newer release (latest is 3.0.3, 2022; upstream main is 10 commits ahead but never touched this constraint either) -- the same abandoned-pin pattern as stellar-sdk/stellar-base, which depend on this gem and are the reason chat can't move to Rails 8. Verified empirically, not just by inspection: installed real activesupport 8.0.0 and activemodel 8.0.0 in an isolated sandbox and ran xdr's full RSpec suite against them (via a temporary Gemfile pin, not committed) -- 122 examples, 0 failures. ActiveSupport::OrderedHash, which this gem relies on and which looked like a plausible removal candidate for a major version bump, is still present and functional in 8.0.0 (confirmed by reading activesupport's own source, not assumed). Widen to < 9.0, matching the same ceiling used for stellar-sdk's own activesupport relax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xdrcaps bothactivesupportandactivemodelat< 8.0, with no release since3.0.3 (2022) and
mainnever having touched this constraint either. This blocks Rails8 for anything depending on this gem transitively (e.g.
stellar-base/stellar-sdk,which depend on
xdr).Verified empirically before opening this, not just by inspection: installed real
activesupport 8.0.0andactivemodel 8.0.0in an isolated sandbox and ran this gem'sfull RSpec suite against them (via a temporary Gemfile pin, not part of this diff) —
122 examples, 0 failures.
ActiveSupport::OrderedHash, which this gem relies on andwhich looked like a plausible removal candidate for a major version bump, is still
present and functional in 8.0.0.
Widened to
< 9.0.