azure_kubernetes_service: add management plane operations - #7
Open
ashishsuneja wants to merge 3 commits into
Open
ashishsuneja wants to merge 3 commits into
ashishsuneja wants to merge 3 commits into
Conversation
- CreateNodePoolAsync: replace manual retry loop with vm_util.Retry (max 5 retries, 30s interval) — consistent with EKS/GKE pattern - UpdateClusterAsync: logging.warning → logging.info for expected pool parse error and fallback tag update Addresses hubatish feedback — use vm_util.Retry, less logging.warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds AKS-specific implementations of management plane async methods,
replacing manual retry loop with structured retry logic.
Main changes
UpgradeNodePoolAsync, UpdateClusterAsync, WaitForOperation,
ResolveNodePoolVersions; manual retry loop → structured retry;
logging.warning → logging.info for expected fallbacks
What for
Provides AKS backend for the kubernetes_management benchmark.
How the change was tested