elastic_kubernetes_service: add management plane operations - #6
Open
ashishsuneja wants to merge 4 commits into
Open
ashishsuneja wants to merge 4 commits into
ashishsuneja wants to merge 4 commits into
Conversation
- GetNodePoolNames: logging.warning → raise GetError - CreateNodePoolAsync: replace manual retry loop with vm_util.Retry (max 5 retries, exponential backoff from 10s) - UpdateClusterAsync: replace manual retry loop with vm_util.Retry (max 10 retries, 30s interval) Addresses hubatish feedback — use vm_util.Retry, let things fail.
elastic_kubernetes_service.py: - Add import time - Gate _DiscoverSubnetsPerAZ behind eks_reserve_capacity_per_az flag - Replace vm_util.Retry decorators with simple retry loops - Fix vm_util.Retry params (exponential_sleep_multiplier not valid) elastic_kubernetes_service_test.py: - Mock time.sleep in EksManagementPlaneTest.setUp to prevent hangs - Update testUpgradeNodePoolAsyncReturnsNgActiveHandle to mock subnets kubernetes_management_benchmark_test.py: - testRunCallsCleanStartSweep: expect 2 calls (Run + before Scenario C) - Add __iter__ to _OpResult for tuple unpacking in tests - Add _OpSamples tuple support for backward compat with tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds EKS-specific implementations of management plane async methods,
replacing manual retry loops with structured retry logic.
Main changes
UpgradeNodePoolAsync, UpdateClusterAsync, WaitForOperation,
ResolveNodePoolVersions; manual retry loops replaced; _DiscoverSubnetsPerAZ
gated behind --eks_reserve_capacity_per_az flag (default off)
plane tests
What for
Provides EKS backend for the kubernetes_management benchmark. Capacity
reservation support is flag-gated (default off) to avoid changing existing
benchmark behavior per cagataygurturk's review comment.
How the change was tested