Repository navigation
fix: don't retry signal job inserts inside a transaction - #229
Merged
zachdaniel merged 1 commit intoOct 25, 2026
Merged
Conversation
zachdaniel
approved these changes
Oct 25, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AshOban.Signalsinserts jobs in the emitting action's transaction. If that insert fails,Oban.Repo.transaction/3retries inside the aborted transaction, and the caller getsconnection is closedafter about 5 seconds instead of the original error. Oban's docs say to passretry: falsethere.This PR passes
retry: falsewhen Oban's repo is in a transaction, and requires Oban 2.24, the first version whose Basic engine passes insert options to its transaction.Contributor checklist
Leave anything that you believe does not apply unchecked.