fix: refuse a value that is not a range on every path that takes one - #2883
Merged
Merged
Conversation
# Conflicts: # lib/ash/type/range.ex # test/type/range_test.exs
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Closes #2882
Summary
A value that is not a range raised instead of being refused —
UndefinedFunctionErrorfromcast_input/2andcast_stored/2,FunctionClauseErrorfromapply_constraints/2.The fix required guarding
extract/1against structs, and givingapply_constraints/2a fallback clause.Requires #2880, since it touched the same two functions.