ci: derive the rustler precompiled crate from the calling repository - #2834
Merged
zachdaniel merged 1 commit intoAug 4, 2026
Merged
Conversation
The build-release job hardcoded igniter_js as the crate name and directory, so every other rustler_precompiled project calling this workflow built the wrong crate on a v* tag. rust-crate-dir did not help, as it was only read by rust-check. build-release now reuses rust-crate-dir for the crate directory, falling back to native/<repository name>, and takes the crate name from the repository name. igniter_js resolves to igniter_js and native/igniter_js exactly as before, and any other project works without configuration. rust-project-name is available for a repository whose crate name differs from its own.
shahryarjb
marked this pull request as draft
August 3, 2026 18:10
zachdaniel
approved these changes
Aug 3, 2026
Contributor
|
LGTM, its a draft though, still waiting on something? |
Contributor
Author
|
Hi dear @zachdaniel , yes i am testing it in local and temporary repo to get 100% confirm |
shahryarjb
marked this pull request as ready for review
August 3, 2026 19:12
Contributor
Author
|
@zachdaniel Thank you i think it is okey for now! |
Contributor
|
🚀 Thank you for your contribution! 🚀 |
jechol
pushed a commit
to jechol/ash
that referenced
this pull request
Aug 15, 2026
…sh-project#2834) The build-release job hardcoded igniter_js as the crate name and directory, so every other rustler_precompiled project calling this workflow built the wrong crate on a v* tag. rust-crate-dir did not help, as it was only read by rust-check. build-release now reuses rust-crate-dir for the crate directory, falling back to native/<repository name>, and takes the crate name from the repository name. igniter_js resolves to igniter_js and native/igniter_js exactly as before, and any other project works without configuration. rust-project-name is available for a repository whose crate name differs from its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-releasehardcodedigniter_jsas the crate name and directory, so any otherrustler_precompiledproject calling this workflow built a crate it does not contain on av*tag;rust-crate-dirdid not help, as it is only read byrust-check.The directory now reuses
rust-crate-dirand falls back tonative/<repository name>, and the crate name falls back to the repository name —igniter_jsresolves toigniter_jsandnative/igniter_jsexactly as before, so nothing changes for existing callers, andrust-project-nameremains for a repository whose crate name differs from its own.For: ash-project/igniter_css#38