Conversation
Explicitly setting `OLD` behavior for policy to silence the warning below and keep behaviour consistent for older and newer cmake version, until we migrate to cmake 3.30. ``` CMake Warning (dev) at cmake/Modules/LibtorrentMacros.cmake:43 (find_package): Policy CMP0167 is not set: The FindBoost module is removed. Run "cmake --help-policy CMP0167" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Call Stack (most recent call first): CMakeLists.txt:821 (find_public_dependency) This warning is for project developers. Use -Wno-dev to suppress it. ```
Owner
|
by suppressing this warning, it makes it more likely to forget replacing the |
Contributor
Author
|
@arvidn it's up to you, I just wanted to keep behaviour consistent across different cmake versions and fix the warning. Let's just switch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly setting
OLDbehavior for policy to silence the warning below and keep behaviour consistent for older and newer cmake version, until we migrate to cmake 3.30.