Skip to content

Remove invocation-reasons.yaml - #126

Merged
JoeStech merged 3 commits into
mainfrom
simplify-logging
Jul 30, 2026
Merged

Remove invocation-reasons.yaml#126
JoeStech merged 3 commits into
mainfrom
simplify-logging

Conversation

@brikin01

Copy link
Copy Markdown
Collaborator

Follow up to #124

Summary

  • Remove the duplicate invocation_reasons.yaml logging.
  • Keep tool calls in /workspace/mcp-traffic.jsonl, with results logged for knowledge base searches.
  • Retain the existing /workspace/error_logging.yaml diagnostics.
  • Standardize both log paths around WORKSPACE_DIR.
  • Document the generated log files in the README.
  • Exclude log files from migrate-ease scans and Git tracking.
  • Fix logger test imports and add the unit tests to CI.

Copilot AI review requested due to automatic review settings July 29, 2026 22:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the separate invocation_reasons.yaml logging path and consolidates tool-call logging into a single workspace traffic log (mcp-traffic.jsonl), while keeping the existing YAML error diagnostics (error_logging.yaml). It also updates documentation and CI to reflect and validate the new logging behavior.

Changes:

  • Consolidate invocation logging to /workspace/mcp-traffic.jsonl and remove the YAML “invocation reasons” log emission.
  • Update user-facing diagnostics/docs to reference the new log files and add .gitignore exclusions.
  • Fix/update invocation logger unit tests and add them to GitHub Actions CI.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
README.md Documents the generated log files and their purpose.
mcp-local/utils/migrate_ease_utils.py Excludes MCP log artifacts from migrate-ease workspace scans.
mcp-local/utils/invocation_logger.py Removes YAML invocation log writes and standardizes JSONL logging under WORKSPACE_DIR.
mcp-local/utils/error_handling.py Updates troubleshooting guidance to reference mcp-traffic.jsonl instead of invocation_reasons.yaml.
mcp-local/tests/test_invocation_logger.py Updates imports and assertions to match the new logging behavior.
mcp-local/tests/constants.py Updates expected workspace listing sample to reference the new log file.
mcp-local/server.py Adjusts logging-related comment to match the consolidated call/result logging approach.
.gitignore Ignores the new generated log artifacts in working trees.
.github/workflows/integration-tests.yml Adds a unit test job to CI to run the invocation logger tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread mcp-local/utils/migrate_ease_utils.py Outdated
Comment thread README.md Outdated
brikin01 and others added 2 commits July 29, 2026 17:11
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@brikin01
brikin01 requested a review from JoeStech July 29, 2026 22:17
@JoeStech
JoeStech merged commit 30a749a into main Jul 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants