Remove invocation-reasons.yaml - #126
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the separate invocation_reasons.yaml logging path and consolidates tool-call logging into a single workspace traffic log (mcp-traffic.jsonl), while keeping the existing YAML error diagnostics (error_logging.yaml). It also updates documentation and CI to reflect and validate the new logging behavior.
Changes:
- Consolidate invocation logging to
/workspace/mcp-traffic.jsonland remove the YAML “invocation reasons” log emission. - Update user-facing diagnostics/docs to reference the new log files and add
.gitignoreexclusions. - Fix/update invocation logger unit tests and add them to GitHub Actions CI.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the generated log files and their purpose. |
| mcp-local/utils/migrate_ease_utils.py | Excludes MCP log artifacts from migrate-ease workspace scans. |
| mcp-local/utils/invocation_logger.py | Removes YAML invocation log writes and standardizes JSONL logging under WORKSPACE_DIR. |
| mcp-local/utils/error_handling.py | Updates troubleshooting guidance to reference mcp-traffic.jsonl instead of invocation_reasons.yaml. |
| mcp-local/tests/test_invocation_logger.py | Updates imports and assertions to match the new logging behavior. |
| mcp-local/tests/constants.py | Updates expected workspace listing sample to reference the new log file. |
| mcp-local/server.py | Adjusts logging-related comment to match the consolidated call/result logging approach. |
| .gitignore | Ignores the new generated log artifacts in working trees. |
| .github/workflows/integration-tests.yml | Adds a unit test job to CI to run the invocation logger tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #124
Summary