[codex] Expose workflow artifact flags on build - #92
Closed
KickNext wants to merge 2 commits into
Closed
Conversation
KickNext
marked this pull request as ready for review
April 20, 2026 00:58
Owner
|
AFAICT this should work now with #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wires the existing workflow-artifact path through to
flutterpi_tool build.The cache layer already knows how to resolve artifacts from a specific GitHub Actions run via the
github-artifacts-*settings, but thebuildcommand never exposed those options on the CLI. In practice that meant issue #89 was real: the plumbing existed, but there was no way to reach it frombuild.This change keeps the scope narrow:
github-artifacts-repo,github-artifacts-runid,github-artifacts-engine-version, andgithub-artifacts-auth-tokenoptions toflutterpi_tool buildbuildinvocation that pins workflow artifactsI did not extend this into an offline or Yocto/meta-flutter workflow. This patch is only about making the existing workflow-backed artifact selection usable from
build.Validation was split by environment. On Windows I ran the targeted
buildcommand tests plusdart analyze. For the full suite, I verified the branch in a real WSL/Linux Flutter environment anddart testpasses there end-to-end. I am calling that out because the current Windows runtime still has unrelated path-separator expectation failures intest/app_builder_test.dart, and this patch does not change that behavior.