Repository navigation
fix: support underscores in package version strings - #266
Merged
pbrisbin merged 4 commits intoMar 2, 2026
Merged
Conversation
pbrisbin
reviewed
Feb 17, 2026
pbrisbin
approved these changes
Feb 17, 2026
pbrisbin
left a comment
pbrisbin
left a comment
Member
There was a problem hiding this comment.
Happy to merge this once tests pass. Thanks!
Contributor
Author
|
I wonder why the test passes in my environment... Please give me a moment to check. |
2 of 7 tasks
This updates the mocks to align with recent changes that execute `makepkg` and `git` via `su -c`. It also adds support for the new `makepkg --packagelist` check, fixing the test failure for packages with underscores in their version strings.
Masterisk-F
force-pushed
the
fix-version-underscores
branch
from
March 1, 2026 11:08
3a01c95 to
88b3ad5
Compare
Contributor
Author
|
I have updated the test functions to align with the change #265 , rebased the branch onto the latest main, and force-pushed. All tests should pass now. |
pbrisbin
approved these changes
Mar 2, 2026
pbrisbin
enabled auto-merge (rebase)
March 2, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
dist/completion/*dist/conf/downgrade.confdoc/*.ronnlocale/*.poREADME.mdDescription
This PR updated the regex patterns of version strings to allow underscores.
I encountered this issue with my AUR package
rubyripperremix, where the installation failed because the version string contains underscores(_).