Conversation
|
鉁旓笍 All good! |
After the push API key, `appsignal install` asks for a collector endpoint and links to the page where a hosted collector is created. Logging and distributed tracing need a collector, so an empty answer asks for confirmation before going on without one. With an endpoint, it also asks for a service name, and writes both to `__appsignal__.py`.
unflxw
force-pushed
the
cli-installer-collector
branch
from
October 1, 2026 15:43
1d7e630 to
36d1e17
Compare
tombruijn
reviewed
Oct 1, 2026
Comment on lines
+72
to
+73
| options["collector_endpoint"] = collector_endpoint | ||
| options["service_name"] = self._service_name() |
Member
There was a problem hiding this comment.
These only get asked for during as a prompt when you run the installer, right?
We should also add them to the CLI options, and help text output, so all the inputs for the installer can be given via both methods.
Comment on lines
+111
to
+115
| def _input_should_continue_without_collector(self) -> bool: | ||
| response = input( | ||
| "Are you sure? Without a collector, logging and distributed tracing" | ||
| " won't work. Continue without one? (y/N): " | ||
| ) |
Member
There was a problem hiding this comment.
I would want to flip the behavior for now so that collector mode is not the default, but when they accept the prompt if they want logging and distributed tracing we ask them for the collector details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements collector mode for the installer, as suggested in https://github.com/appsignal/appsignal-docs/pull/339#pullrequestreview-5365577616.
After the push API key,
appsignal installasks for a collectorendpoint and links to the page where a hosted collector is created.
Logging and distributed tracing need a collector, so an empty answer
asks for confirmation before going on without one. With an endpoint, it
also asks for a service name, and writes both to
__appsignal__.py.