Redact sensitive values in error descriptions#197
Open
fhwvtqdc2q-svg wants to merge 1 commit into
Open
Conversation
Author
|
Validation note: because this Windows environment cannot run Swift/Xcode locally, I validated the same code on a fork-only validation branch using macOS GitHub Actions. The validation branch adds only a workflow file on top of this PR's code. Run: https://github.com/fhwvtqdc2q-svg/swift-openapi-runtime/actions/runs/25954832217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ClientError and ServerError include request/response metadata in their printable descriptions. Those descriptions can be logged by applications, and currently include raw header values such as Authorization, Cookie, and Set-Cookie, as well as query-string tokens. Redacting those values keeps the diagnostics useful while reducing accidental credential leakage.
Testing
Not run locally because this environment is Windows and does not have Swift/Xcode installed. A macOS GitHub Actions validation run will be triggered on the fork branch.