Skip to content

fix(kbagent): reap zombie processes - #10772

Merged
leon-ape merged 10 commits into
release-1.1from
bugfix/10762-kbagent-zombie-reaping-1.1
Aug 13, 2026
Merged

leon-ape merged 10 commits into
release-1.1from
bugfix/10762-kbagent-zombie-reaping-1.1

Conversation

@leon-ape

@leon-ape leon-ape commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • backport fix(kbagent): reap zombie processes #10763 to release-1.1
  • run kbagent under tini and ship tini-static in the tools image
  • preserve the legacy custom-image init image/command pair for existing Pods while new or recreated Pods copy both binaries
  • centralize the current and legacy kbagent Pod contracts for Component and InstanceSet consumers

Backport notes

The commits were cherry-picked in order from #10763. Release-only resolutions keep the release-1.1 Apps implementation and adapt the branch's older getPodUpdatePolicy test signature.

Closes #10762

Verification

  • scripts/codex-go-test.sh ./cmd/kbagent ./pkg/kbagent -count=1
  • scripts/codex-go-test.sh -overlay=<generated-mock-overlay> ./pkg/controller/component ./pkg/controller/instanceset -count=1
  • scripts/codex-go-test.sh -overlay=<generated-mock-overlay> ./controllers/apps/component -count=1
  • built docker/Dockerfile-tools
  • verified /bin/kbagent and /bin/tini-static are executable in the built image; tini reports 0.19.0

@leon-ape
leon-ape requested a review from a team as a code owner August 13, 2026 06:49
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@github-actions github-actions Bot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 13, 2026
@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Aug 13, 2026
@leon-ape leon-ape changed the title fix(kbagent): reap zombie processes [release-1.1] fix(kbagent): reap zombie processes Aug 13, 2026
@leon-ape leon-ape added this to the Release 1.1.0 milestone Aug 13, 2026
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.21053% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.30%. Comparing base (dbf783b) to head (6d910ef).

Files with missing lines Patch % Lines
pkg/controller/instanceset/in_place_update_util.go 79.54% 6 Missing and 3 partials ⚠️
pkg/controller/instanceset/instance_util.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1   #10772      +/-   ##
===============================================
+ Coverage        54.25%   54.30%   +0.04%     
===============================================
  Files              545      546       +1     
  Lines            61364    61431      +67     
===============================================
+ Hits             33293    33359      +66     
- Misses           24876    24878       +2     
+ Partials          3195     3194       -1     
Flag Coverage Δ
unittests 54.30% <84.21%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape
leon-ape merged commit ee36c92 into release-1.1 Aug 13, 2026
34 of 36 checks passed
@leon-ape
leon-ape deleted the bugfix/10762-kbagent-zombie-reaping-1.1 branch August 13, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nopick Not auto cherry-pick when PR merged size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] kbagent PID 1 does not reap orphaned action processes, exhausting node PID limit

2 participants