fix(instanceset): round rolling update replicas up - #10676
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10676 +/- ##
==========================================
+ Coverage 64.85% 64.94% +0.09%
==========================================
Files 506 506
Lines 63316 63335 +19
==========================================
+ Hits 41062 41132 +70
+ Misses 18611 18571 -40
+ Partials 3643 3632 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 14, 2026
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollingUpdate.replicasby rounding up in both the legacy Pod and Instance API update pathsrollingUpdate.maxUnavailablebehavior: round percentages down and clamp the result to at least 1reconciler_update_test.gofilesmainFor three instances with both fields set to
34%, the resolved quotas arereplicas: 2andmaxUnavailable: 1. This lets the requested rollout window make progress without increasing the established unavailability budget.Tests
scripts/codex-go-test.sh ./pkg/controller/instanceset -run TestAPIs -ginkgo.focus="update reconciler test" -count=1scripts/codex-go-test.sh ./pkg/controller/instanceset2 -run TestParseReplicasNMaxUnavailable -count=1Fixes #10641