Skip to content

Remove unused Ruby client reply helpers#3395

Open
kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk:seqid-rb-cleanup
Open

Remove unused Ruby client reply helpers#3395
kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk:seqid-rb-cleanup

Conversation

@kpumuk
Copy link
Copy Markdown
Member

@kpumuk kpumuk commented Apr 14, 2026

This is a follow-up to #3345. I left the old helpers around, so that code generated with the compiler pre- and post- seqid change would work (although pre- would not generate correct sequence IDs nor validate them).

With this cleanup we force people to re-generate, as per Ruby documentation on version upgrade. This will also go into the next release (0.24.0), so I feel like it should not affect anybody.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable bot added the ruby label Apr 14, 2026
@kpumuk kpumuk force-pushed the seqid-rb-cleanup branch from 90b6621 to 7d4c6ff Compare April 15, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant