THRIFT-5940: Make generated Ruby code RuboCop compliant#3388
Open
kpumuk wants to merge 1 commit intoapache:masterfrom
Open
THRIFT-5940: Make generated Ruby code RuboCop compliant#3388kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk wants to merge 1 commit intoapache:masterfrom
Conversation
mergeable
bot
added
compiler
github_actions
Jens-G
approved these changes
Apr 13, 2026
| stringstream docs(tdoc->get_doc(), std::ios_base::in); | ||
| string line; | ||
| while (std::getline(docs, line)) { | ||
| out.indent() << "#"; |
Member
There was a problem hiding this comment.
std::getline() only strips \n, so a CRLF-terminated blank line leaves line == "\r" -> line.empty() is false -> output becomes # \r —> reintroducing trailing whitespace.
Reference: https://en.cppreference.com/w/cpp/string/basic_string/getline
See also:
Member
Author
There was a problem hiding this comment.
Oh wow, it has been a while since I touched C++. Thank you!
I am thinking about enabling Ruby compiler on compiler tests and starting adding those (currently only C++, .NET and Ocaml are there).
Client: rb Co-Authored-By: OpenAI Codex (GPT-5.4) <codex@openai.com>
mergeable
bot
added
the
build and general CI
Jens-G
reviewed
Apr 14, 2026
| REQUIRE(generated_content.find("\r") == string::npos); | ||
| REQUIRE(generated_content.find("# * first line\n") != string::npos); | ||
| REQUIRE(generated_content.find("# *\n") != string::npos); | ||
|
|
Member
There was a problem hiding this comment.
I just noticed we may not have a CI step yet that runs these tests.
| REQUIRE(generated_content.find("# *\n") != string::npos); | ||
|
|
||
| std::remove(thrift_path.c_str()); | ||
| } |
Member
There was a problem hiding this comment.
The generated gen-rbstuff is not cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses Rubocop offenses in the generated code, mostly spacing:
message=nilinstead ofmessage = nil#(trailing whitespace) instead of#Additionally, we generate all Thrift files for Ruby so that SCA job actually ensures they are compliant.
[skip ci]anywhere in the commit message to free up build resources.