Replace addr with factory in TServerSocket#3379
Open
qr243vbi wants to merge 1 commit intoapache:masterfrom
Open
Replace addr with factory in TServerSocket#3379qr243vbi wants to merge 1 commit intoapache:masterfrom
qr243vbi wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
This allows to use named pipes from go-winio. |
fishy
reviewed
Apr 9, 2026
qr243vbi
force-pushed
the
patch-1
branch
4 times, most recently
from
d57b3cc to
01ef926
Compare
qr243vbi
force-pushed
the
patch-1
branch
2 times, most recently
from
61aaeaa to
160aec1
Compare
fishy
reviewed
Apr 9, 2026
fishy
reviewed
Apr 9, 2026
fishy
reviewed
Apr 9, 2026
fishy
reviewed
Apr 9, 2026
fishy
reviewed
Apr 11, 2026
Member
fishy
left a comment
fishy
left a comment
There was a problem hiding this comment.
I still don't think "factory" is the best term here, maybe "listener" or something like that?
Also please squash your commits.
Author
Right |
qr243vbi
requested review from
Jens-G,
emmenlau,
jimexist and
mhlakhani
as code owners
mergeable
bot
added
haxe
java
kpumuk
removed
javascript
Member
|
the code doesn't compile: https://github.com/apache/thrift/actions/runs/24448228720/job/71489703825?pr=3379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]anywhere in the commit message to free up build resources.