Skip to content

Fix RabbitMQ/PostgreSQL/Zabbix meter source miswires - #14171

Merged
wu-sheng merged 2 commits into
apache:masterfrom
songzhendong:fix/rabbitmq-singleblock-sbcs
Oct 27, 2026
Merged

wu-sheng merged 2 commits into
apache:masterfrom
songzhendong:fix/rabbitmq-singleblock-sbcs

Conversation

@songzhendong

@songzhendong songzhendong commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix three meter source miswires so chart names match the data they plot. Metric names are unchanged; Horizon / UI templates do not need updates.

RabbitMQ - singleblock used mbcs

  • Why: meter_rabbitmq_node_allocated_singleblock_used / _unused copied kind=mbcs from the multiblock rules, so Singleblock charts showed the same series as Multiblock.
  • Fix: use Erlang kind=sbcs (single-block carriers). Multiblock stays on mbcs / mbcs_pool.
  • UI: Horizon Multi/Single-block Memory still binds meter_rabbitmq_node_allocated_singleblock_*.

PostgreSQL - temporary files rate used temp_bytes

  • Why: meter_pg_temporary_files_rate / meter_pg_instance_temporary_files_rate read pg_stat_database_temp_bytes, so Temporary Files / s showed byte throughput instead of file-creation rate.
  • Fix: use pg_stat_database_temp_files. Align backend-postgresql-monitoring.md with PostgreSQL's temp_files wording.
  • UI: Horizon Temporary Files / s still binds meter_pg_temporary_files_rate.

Zabbix VM - filesystem % used inode pused

  • Why: meter_vm_filesystem_percentage used vfs.fs.inode pused, so File System Mountpoint Usage showed inode occupancy instead of disk space %.
  • Fix: vfs.fs.size used/total * 100, same meaning as OTEL / Telegraf VM rules.
  • Cleanup: drop unused vfs.fs.inode[/,pused] and unused duplicate vm.memory.size[pavailable] from requiredZabbixItemKeys (not referenced by metrics/UI).
  • UI: Horizon FS % / Filesystem Usage (%) still binds meter_vm_filesystem_percentage.

Test plan

  • MAL fixtures updated for RabbitMQ / PostgreSQL / Zabbix
  • Related e2e green on fork CI: RabbitMQ, PostgreSQL Prometheus, VM Zabbix
  • Fork CI fully green (Required + CI success)
  • Apache CI

Note

This change only touches RabbitMQ / PostgreSQL / Zabbix MAL YAML, fixtures, and docs. Metric names are unchanged, so no Horizon dashboard updates are required.

songzhendong and others added 2 commits October 27, 2026 07:17
- `allocated_singleblock_unused` now subtracts `blocks_size` from
  `carriers_size` for `kind=sbcs`, as RabbitMQ's Erlang memory
  allocators dashboard does; it reported the whole carriers size.
  The fixture gives sbcs distinct blocks/carriers values so the
  subtraction is covered.
- `meter_vm_filesystem_percentage` reads the agent's
  `vfs.fs.size[/,pused]`, the value `df` and the Telegraf VM rule
  report, instead of used / total, which also no longer depends on
  `used` and `total` arriving in the same agent send.
  `meter_vm_vfs_fs_size` leaves `pused` out and stays bytes only.
- changes.md: note that values stored before the upgrade keep the
  old numbers, and drop the claim that Zabbix matches the OTEL rule.
@wu-sheng wu-sheng added this to the 11.1.0 milestone Oct 27, 2026
@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! backend OAP backend related. labels Oct 27, 2026
@wu-sheng
wu-sheng merged commit cc6ed62 into apache:master Oct 27, 2026
939 of 961 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants