fix: offload websocket reconnect from shared timer to dedicated executor - #6898
Open
wy471x wants to merge 1 commit into
Open
fix: offload websocket reconnect from shared timer to dedicated executor#6898wy471x wants to merge 1 commit into
wy471x wants to merge 1 commit into
Conversation
healthCheck() called reconnectBlocking() on the shared wheel timer's single-thread executor, blocking all other timer tasks (other clients' health checks, masterCheck) during TCP connect timeout. Offload reconnect to a dedicated CachedThreadPool executor with exponential backoff + jitter (1s-60s) and an AtomicBoolean guard to prevent concurrent reconnect attempts. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShenyuWebsocketClient.healthCheck()previously calledreconnectBlocking()directly on the shared wheel timer's single-thread executor. When an admin was unreachable, the TCP connect timeout blocked all other timer tasks (other clients' health checks,masterCheck), causing missed heartbeats and delayed failover.CachedThreadPoolexecutor so the timer thread is never blocked.AtomicBooleanguard to prevent concurrent reconnect attempts for the same client.Test plan
calculateBackoff()returns 0 for no failures, exponential growth for failures 1-10, capped at 60s, with jitterhealthCheck()resets backoff on healthy connection, does not double-submit reconnectsdoReconnect()increments backoff on failure (capped at 10), resetsreconnectingin finally, applies backoff sleep, preserves interrupt statusclose #6844