RATIS-2511. Follower should throw ReadException if it is installing snapshot#1444
Open
ivandika3 wants to merge 3 commits intoapache:masterfrom
Open
RATIS-2511. Follower should throw ReadException if it is installing snapshot#1444ivandika3 wants to merge 3 commits intoapache:masterfrom
ivandika3 wants to merge 3 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When Ratis follower is installing snapshot, its appliedIndex will not advance until the snapshot is installed. This can cause all linearizable follower read on this node to timeout due to the client timeout (default is 3s).
Instead of waiting until the client timeout, Ratis follower can check whether it is currently installing snapshot and trigger failover immediately if it does. Any new or pending read requests in the follower need to return ReadException.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2511
How was this patch tested?
Integration test.
Clean CI: https://github.com/ivandika3/ratis/actions/runs/25156971002