refactor: inline onEvent into MergeHub.tryProcessNext#2901
Open
He-Pin wants to merge 1 commit intoapache:mainfrom
Open
refactor: inline onEvent into MergeHub.tryProcessNext#2901He-Pin wants to merge 1 commit intoapache:mainfrom
He-Pin wants to merge 1 commit intoapache:mainfrom
Conversation
Drop the Boolean-returning onEvent helper; pattern-match the event directly inside tryProcessNext. Element pushes and exits, Register and Deregister recurse via @tailrec to drain control messages from the queue. Same protocol, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boolean-returningonEventhelper directly intoMergedSourceLogic.tryProcessNextElementpushes and exits,Register/Deregistercontinue the@tailrecloop to drain control messages from the queueMotivation
onEventreturned aBooleanflag whose only purpose was to telltryProcessNextwhether to continue looping. Folding the dispatch into the call site removes the indirection and makes the loop / exit conditions read in one place.Test plan
sbt scalafmtAllsbt stream/compile—@tailrecaccepted, no warningssbt "stream-tests/testOnly org.apache.pekko.stream.scaladsl.HubSpec"— 48/48 in 18s