Open
Conversation
github-actions
bot
added
Area: Networking
Use conn->dev directly when it is already available Signed-off-by: Jerry Ma <shichunma@bestechnic.com>
masc2008
force-pushed
the
net-tcp-improve-txnotify
branch
from
cf7b711 to
e310929
Compare
xiaoxiang781216
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use conn->dev directly when it is already available
Summary
Use
conn->devdirectly intcp_send_txnotify()when the device is already available, and keep the existing IPv4/IPv6 fallback path when it is not.Also fix the grammar in the function comment.
Impact
This is a small networking change in
net/tcp/tcp_send.c.It keeps the existing fallback behavior when
conn->devisNULLand uses the cached device directly when available.Test
On BES chips, since there is no related log when do this, no need to attach log.
from the code, it's a good improvement.