CI: CMake Added a folder nxtmpdir for storing third-party packages#18749
Draft
simbit18 wants to merge 3 commits intoapache:masterfrom
Draft
CI: CMake Added a folder nxtmpdir for storing third-party packages#18749simbit18 wants to merge 3 commits intoapache:masterfrom
simbit18 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Could you test locally using |
Contributor
Author
|
Hi @fdcavalcanti here it is: esp32-c3-zero:nshI've got to sign off now – I've got more tests tomorrow!!! :) |
- It is now possible to create folder for third-party packages in CMake as well. (Aligned with Make) Signed-off-by: simbit18 <simbit18@gmail.com>
- Boards build by CMake
esp32c3-xiao
esp32-c3-zero
Signed-off-by: simbit18 <simbit18@gmail.com>
- Moved the creation of the `nxtmpdir` folder for third-party packages to the root `CMakeLists.txt` file. Signed-off-by: simbit18 <simbit18@gmail.com>
8b5534c to
eb3f13b
Compare
Member
@simbit18 Aha this is very interesting. Does it mean I need to delete |
Contributor
Author
|
Hi @lupyuen, yes, that would probably be best, just to be on the safe side. At the moment, the esp-hal-3rdparty repository is cloned just once and used for the Make build of all Espressif boards. So, of course, there is a chance that Git might not work properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testbuild.sh:
CMakeLists.txt:
nxtmpdirfolder for third-party packages to the rootCMakeLists.txtfile.ci/testlist/risc-v-02.dat:
CMake,esp32c3-xiao:nimble
CMake,esp32c3-xiao:gpio
CMake,esp32c3-xiao:wifi
CMake,esp32c3-xiao:usbnsh
CMake,esp32-c3-zero:wifi
CMake,esp32-c3-zero:jumbo
CMake,esp32-c3-zero:sta_softap
CMake,esp32-c3-zero:usbnsh
Impact
Impact on user: NO
Impact on build: NO
Impact on hardware: NO
Impact on documentation: NO
Impact on security: NO
Impact on compatibility: NO
Testing
GitHub
https://github.com/simbit18/manual-nuttx-ci/actions/runs/24516760711/job/71663210962#logs