Skip to content

JS: reformatting fails for classes that contain a static initializer#9358

Merged
ebarboni merged 1 commit intoapache:deliveryfrom
matthiasblaesing:js_static_init
Apr 22, 2026
Merged

JS: reformatting fails for classes that contain a static initializer#9358
ebarboni merged 1 commit intoapache:deliveryfrom
matthiasblaesing:js_static_init

Conversation

@matthiasblaesing
Copy link
Copy Markdown
Contributor

static initializers have no identifier so don't try to scan them

Closes: #9339

static initializers have no identifier so don't try to scan them

Closes: apache#9339
@matthiasblaesing matthiasblaesing added this to the NB30 milestone Apr 21, 2026
@matthiasblaesing matthiasblaesing added JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Apr 21, 2026
@matthiasblaesing matthiasblaesing linked an issue Apr 21, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works !!

@ebarboni ebarboni merged commit 9394cb2 into apache:delivery Apr 22, 2026
29 checks passed
@matthiasblaesing
Copy link
Copy Markdown
Contributor Author

@ebarboni thanks for review and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Javascript auto-complete for class with static initializator

2 participants