fix(desktop): restore right workbar scrolling - #5000
Conversation
Constrain the right overlay grid row so tall faces stay within the viewport and their local scroll containers retain overflow. Add a Storybook regression covering paginated Changes content and scrollTop movement. Fixes apache#4999 Generated-by: Codex
me2seeks
left a comment
There was a problem hiding this comment.
Automated review by OpenAI Codex, operated by me2seeks, at 623ac3e5533f3b69263e6a1c94681a1d43a63ca8. This is an automated technical assessment, not an independent human review. Approval is submitted at the operator's explicit direction.
No actionable findings. Traced WorkbarPanel -> Astryx Section inner height:100% wrapper -> review panel overflow owner. A headless Chromium layout reproduction using the exact before/after shell CSS and those production sizing rules changes the tall face from clientHeight=1600, scrollTop=0 to clientHeight=560, scrollTop=500. The story now expands the second page and asserts actual scrolling. #4967 overlaps the same row constraint and will need reconciliation after this lands.
- Optimal for the actual problem: Yes; the change addresses the defect at its existing owner.
- Production code that can be deleted: None identified.
- Low-quality tests that can be deleted or replaced: None identified.
- Deeper refactor: No deeper refactor is needed.
- Ready to merge: Content is ready; merge remains conditional on current required checks and conflict state.
- Residual risks / verification: Local Chromium sizing reproduction passed; hosted test is SUCCESS at this head. The complete Storybook and Electron suites were not rerun locally. User-visible scrolling changes; material protected-area changes require independent human review under CONTRIBUTING.md.
Summary
scrollTop.Fixes #4999
Verification
clientHeight=1305,scrollHeight=1305,scrollTop=0.clientHeight=868,scrollHeight=1289, and scrolled 421px; Trace measuredclientHeight=868,scrollHeight=1416, and scrolled 548px.npm run build-storybook -w @maka/desktopnpm run smoke:storybook -w @maka/desktop— 326 stories, 353 theme rendersnpm run typecheck:stories -w @maka/desktopnpm run check:architecture -w @maka/desktopnpm run build:renderer -w @maka/desktopnpx biome check apps/desktop/stories/session-workbar.stories.tsx apps/desktop/src/renderer/styles/workbar/shell.cssgit diff --checkAI use
Select exactly one:
Tool(s) and scope:
Codex diagnosed the shared Grid sizing regression, implemented the CSS fix and Storybook regression, ran verification, and prepared the issue, commit, and PR description.
Checklist
Does this PR entail a change in behavior?