fix(ui): keep task context menu open - #4988
Merged
Astro-Han merged 1 commit intoSep 7, 2026
Merged
Conversation
The menu opened before the secondary-button gesture ended, so native popover light dismiss closed it on release. Deferring activation until after pointerup completes keeps the menu open. CLOSES apache#4983 Generated-by: Codex Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Astro-Han
approved these changes
Sep 7, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused fix. Reviewed caed2e6; no blocking findings. Verified the production component in Chromium for deferred opening, post-release and keyboard invocation, and cancellation, with no page errors. These checks dispatch DOM events; native macOS gesture verification is reported in the PR. CI is green. Review assisted by Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delay opening a task's context menu until the secondary-button release and
its native default action have completed. This prevents Chromium's popover
light-dismiss behavior from immediately closing the menu on macOS while
preserving keyboard and post-release context-menu invocation.
Fixes #4983
Verification
node --test packages/ui/dist/__tests__/session-history-multi-select.test.js— 22 passed, including a regression test that fails before the fix
npx biome check packages/ui/src/session-history-list.tsx packages/ui/src/__tests__/session-history-multi-select.test.tsx— passed
npm --workspace @maka/core run buildandnpm --workspace @maka/ui run build— passedthe secondary button is released
npm test— all reported assertions passed, but the parallel workspacerunner returned code 1 once for MCP and once for CLI; isolated reruns passed
186/186 and 861/861 respectively
AI use
Select exactly one:
Tool(s) and scope: Codex diagnosed the pointer-event ordering, implemented
the focused fix and regression test, and ran verification. The commit includes
the required
Generated-by: Codextrailer.Checklist
Does this PR entail a change in behavior?