Repository navigation
feat(contributor-growth): recent-activity check and stricter pre-filter options for candidate-screen - #1592
Merged
Conversation
…er options for candidate-screen The pre-filter kept anyone whose merged PRs or reviews reached half of a floor over the whole window. On a large project that keeps people who stopped contributing months ago and far more people than anyone reads, and there was no way to tighten it beyond the ratio. Three settings in contributor-nomination-config.md control it now: screen_recent_activity_months (default 4) drops anyone with no change landed in the last N months, for both targets; screen_prefilter_require (any, the previous behaviour, or all) decides whether one count is enough; screen_prefilter_targets (committer, the previous behaviour, or both) extends the count check to the governance-body pool. Every drop is still logged with its counts and the check that dropped it. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
candidate-screen's pre-filter kept anyone whose merged PRs or reviewsreached half of a floor over the whole window. On a large project that
keeps people who stopped contributing months ago, and far more people
than anyone reads; the ratio was the only knob.
Three settings in
contributor-nomination-config.mdcontrol it now:screen_recent_activity_months40turns it offscreen_prefilter_requireany(previous behaviour)allrequires both merged PRs and reviews to reach their share of the floorscreen_prefilter_targetscommitter(previous behaviour)bothapplies the count check to the governance-body pool tooThe recent-activity check is one more count-only query per person
(
list_authored(state: landed, since: end - N months, count_only)).Every drop is still logged with its counts and the check that dropped it,
and the floors are still used only here.
The new default for
screen_recent_activity_monthschanges behaviourfor existing users: people with nothing landed in the last four months
are no longer measured. Set it to
0to keep the old behaviour.Type of change
Test plan
is dropped,
require: alldrops one who reaches only one floor, andtargets: bothdrops a governance-body candidate below both floorsscreen_recent_activity_months: 0so they keep testing what they tested
prek run --all-filespassesGenerated-by: Claude Opus 5
🤖 Generated with Claude Code