Repository navigation
Conversation
Contributor
Author
|
Also waiting #16952 to be merged to solve the test failure. |
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DocValues range query currently use
DocValuesValueRangeIteratorwhen noDocValuesSkipperis available. Its defaultintoBitSetimplementation is predicating doc by doc, even thoughNumericDocValues,SortedNumericDocValuesandSortedDocValuesalready provide bulk range APIs.This change allows
DocValuesValueRangeIteratorto use an optional bulk range when no skipper is available.It enables the classes:
NumericDocValues.rangeIntoBitSetSortedNumericDocValues.rangeIntoBitSetSortedDocValues.ordinalRangeIntoBitSetOnce the current PR is merged, I will enable
SortedSetDocValues.ordinalRangeIntoBitSetwith #16869.While testing this change, I encountered a test failure caused by an overflow when transforming query bounds for GCD-encoded DocValues #16896, so this change depends on that fix.
Benchmark
I use SortedNumericDocValuesRangeQueryBenchmark to test without skip indexes:
gains ranging from 18.3% to 33.9%, with no performance regression was observed.