Skip to content

fix(frontend): sort question list by expiration date, closed at end (#32) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milamberspace wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(frontend): sort question list by expiration date, closed at end (#32) #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions frontend/src/components/QuestionList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,18 @@

// "Recent activity": every question (open or closed) updated in the
// past 14 days, as served by the backend's `recent` array. Project-
// scoped per `inRecentScope`; the backend already orders by
// updated_at DESC, so we preserve that order rather than re-sorting
// by created_at.
// scoped per `inRecentScope`. Sorted: open questions first (soonest
// to expire), then closed/withdrawn (most recently expired last).
$: recent = allRecent
.filter(inRecentScope)
.filter((q) => matchesFilter(q, filter));
.filter((q) => matchesFilter(q, filter))
.sort((a, b) => {
const aOpen = a.status === "open";
const bOpen = b.status === "open";
if (aOpen !== bOpen) return aOpen ? -1 : 1;
if (aOpen) return Date.parse(a.closes_at) - Date.parse(b.closes_at);
return Date.parse(b.closes_at) - Date.parse(a.closes_at);
});

onMount(load);
</script>
Expand Down