HIVE-14609: HS2 cannot drop a function whose associated jar file has been removed#6447
Open
abstractdog wants to merge 2 commits intoapache:masterfrom
Open
HIVE-14609: HS2 cannot drop a function whose associated jar file has been removed#6447abstractdog wants to merge 2 commits intoapache:masterfrom
abstractdog wants to merge 2 commits intoapache:masterfrom
Conversation
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
deniskuzZ
reviewed
Apr 24, 2026
| super(queryState, db); | ||
| } | ||
|
|
||
| protected FunctionInfo getFunctionInfo(String functionName) throws SemanticException { |
Member
There was a problem hiding this comment.
why do we need this 1-liner function call?
deniskuzZ
reviewed
Apr 24, 2026
| // getFunctionInfo returns null when the function's JAR resource cannot be loaded (e.g. the | ||
| // HDFS file was deleted). For permanent functions fall back to a direct metastore lookup so | ||
| // that an orphaned definition can still be removed without the JAR being present. | ||
| if (!isTemporary && functionExistsInMetastore(functionName)) { |
Member
There was a problem hiding this comment.
could we refactor the upper function to return all fns registered in HMS? not sure, but i think function registry should handle that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add an extra metastore call in
DropFunctionAnalyzerif the function info retrieval wasn't successful.Why are the changes needed?
Because with the patch it's impossible to DROP a function whose associated jar is deleted, which is extremely inconvenient.
Does this PR introduce any user-facing change?
Under normal circumstances, no.
How was this patch tested?
Unit test added (
testDropSucceedsWhenJarUnavailableButFunctionInMetastore), also, more importantly, local HS2 testing is done, confirmed the behavior pre/post patch:important to note that DROP FUNCTION is apparently successful w/wo the patch, and and exception appears in HS2 logs (which is good), but the function is only dropped successfully with the patch
pre-patch:
post-patch:
in the log:
the exception appears in the log in both cases: