Fix NPE in canCompleteSwap when path doesn't exist - #3162
Open
waterWang wants to merge 1 commit into
Open
Conversation
When baseAccessor.getChildNames() returns null because the current state path doesn't exist, iterating over the result causes a NullPointerException. Added a null check that returns true when no current states are found, indicating the swap is complete. Fixes apache#3069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
baseAccessor.getChildNames()returns null because the current state path for the swap-out instance doesn't exist, iterating over the result causes aNullPointerException.Fix
Added a null check that returns
truewhen no current states are found, indicating the swap is complete (there are no current states to transfer).Root Cause
BaseDataAccessor.getChildNames()returns null when the ZNode path doesn't exist. The code at line 555 iterates over the result without a null check, causing NPE.Fixes #3069
Testing