HBASE-30070 Replace deprecated JRuby LoadService#findFileForLoad with $LOAD_PATH.resolve_feature_path#8052
HBASE-30070 Replace deprecated JRuby LoadService#findFileForLoad with $LOAD_PATH.resolve_feature_path#8052jinhyukify wants to merge 1 commit intoapache:masterfrom
Conversation
… $LOAD_PATH.resolve_feature_path
|
Interesting, I'm not sure how many users rely on loading a script file this way, but we should definitely update the code. Here's my understanding of the issue. In previous versions, the mkdir -p scripts
echo "list; exit" > scripts/list.rb
RUBYLIB=scripts bin/hbase shell -n list.rbHowever, this no longer works on the latest master: I can confirm the patch fixes the problem. That said, I'm not sure loading script files from arbitrary Script resolution from And by default, the shell doesn't add extra directories to The patch is fine and is good to merge, but I think this is a good chance to discuss the concern. |
|
@NihalJain Hi, could you take a look at this? We still have some code that was removed in JRuby 9.4. |
Jira https://issues.apache.org/jira/browse/HBASE-30070