HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception#8049
Closed
sharmaar12 wants to merge 1 commit intoapache:HBASE-29081_rebasedfrom
Closed
HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception#8049sharmaar12 wants to merge 1 commit intoapache:HBASE-29081_rebasedfrom
sharmaar12 wants to merge 1 commit intoapache:HBASE-29081_rebasedfrom
Conversation
vaijosh
reviewed
Apr 9, 2026
| } | ||
|
|
||
| @Test(expected = DoNotRetryIOException.class) | ||
| @Test(expected = WriteAttemptedOnReadOnlyClusterException.class) |
Contributor
There was a problem hiding this comment.
Hi @sharmaar12
Since we’ve migrated to JUnit 5, we should move away from the outdated expected parameter in the @test annotation. Please use assertThrows instead. Additionally, the current tests don't verify the exception message—using assertThrows will allow you to capture the exception and assert against the message. While the old pattern might work for legacy branches, we need to follow the new standard for any merges into master.
Author
There was a problem hiding this comment.
@vaijosh Noted. I will create another PR for HBASE-29081 branch and do the changes there.
Contributor
|
@sharmaar12 Please use the original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.