HBASE-30063 Upgrade hbase-server to use junit5 Part7#8031
Merged
liuxiaocs7 merged 4 commits intoapache:masterfrom Apr 10, 2026
Merged
HBASE-30063 Upgrade hbase-server to use junit5 Part7#8031liuxiaocs7 merged 4 commits intoapache:masterfrom
liuxiaocs7 merged 4 commits intoapache:masterfrom
Conversation
Member
liuxiaocs7
commented
Apr 8, 2026
- see: HBASE-30063
Apache9
approved these changes
Apr 8, 2026
There was a problem hiding this comment.
Pull request overview
Migrates a large set of hbase-server master tests from JUnit 4 to JUnit 5, aligning test annotations, assertions, and classification/grouping with the JUnit Platform used by the rest of the codebase.
Changes:
- Replaces JUnit4 lifecycle/category APIs (
@BeforeClass/@AfterClass,@Category,Assert.*, rules) with JUnit5 equivalents (@BeforeAll/@AfterAll,@Tag,Assertions.*, extensions/TestInfo). - Updates parameterized testing patterns to JUnit5 via
@HBaseParameterizedTestTemplate+@TestTemplate+parameters()stream. - Cleans up/modernizes assertion message ordering and disables ignored tests using JUnit5
@Disabled.
Reviewed changes
Copilot reviewed 78 out of 78 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestWarmupRegion.java | JUnit5 annotations/tags/assertions migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestUnknownServers.java | JUnit5 migration; uses JUnit5 tagging. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java | JUnit5 annotations/tags/assertions migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitRegionWhileRSCrash.java | JUnit5 migration; tags/assertions update. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java | JUnit5 migration; tags/assertions update. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestShutdownWithNoRegionServer.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestShutdownBackupMaster.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestServerCrashProcedureStuck.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestServerCrashProcedureCarryingMetaStuck.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRoundRobinAssignmentOnRestartSplitWithoutZk.java | JUnit5 tag migration for subclass test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRoundRobinAssignmentOnRestart.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java | Converts JUnit4 parameterized test to JUnit5 @HBaseParameterizedTestTemplate. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRetainAssignmentOnRestartSplitWithoutZk.java | JUnit5 tag migration for subclass test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRetainAssignmentOnRestart.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRestartWithEmptyWALDirectory.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionState.java | JUnit5 tag/assertion migration; introduces TestInfo usage. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionsRecoveryConfigManager.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionsRecoveryChore.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlansWithThrottle.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement2.java | JUnit5 lifecycle/tag migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java | JUnit5 lifecycle/tag/assertion migration; replaces @Ignore with @Disabled. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRecreateCluster.java | JUnit5 lifecycle/tag migration; introduces TestInfo usage. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOldWALsDirSizeChore.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestNewStartedRegionServerVersion.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMigrateNamespaceTable.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMigrateAndMirrorMetaLocations.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaShutdownHandler.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaAssignmentWithStopMaster.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMergeTableRegionsWhileRSCrash.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterUseIp.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterTransitions.java | JUnit5 lifecycle/tag/assertion migration; replaces @Ignore with @Disabled. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java | JUnit5 lifecycle/tag migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRepairMode.java | JUnit5 lifecycle/tag migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRegionMutation2.java | JUnit5 migration + refactor to parameterize superclass cluster setup. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRegionMutation1.java | JUnit5 lifecycle/tag migration + refactor for subclass-driven cluster config. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterQosFunction.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java | JUnit5 lifecycle/tag migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java | JUnit5 lifecycle/tag/assertion migration; replaces JUnit4 asserts. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetricsWrapper.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterHandlerFullWhenTransitRegion.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystemWithWALDir.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystemWithStoreFileTracking.java | JUnit5 lifecycle/tag/assertion migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystem.java | JUnit5 lifecycle/tag/assertion migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailoverBalancerPersistence.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java | JUnit5 tag/assertion migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterDryRunBalancer.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterCoprocessorServices.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterChoreScheduled.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterBalanceThrottling.java | JUnit5 lifecycle/tag/assertion migration; replaces @Ignore with @Disabled. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterBalancerNPE.java | JUnit5 lifecycle/tag migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterAbortAndRSGotKilled.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java | JUnit5 lifecycle/tag/assertion migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestLoadProcedureError.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestListTablesByState.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterCommandLine.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestGetReplicationLoad.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestGetLastFlushedSequenceId.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestGetInfoPort.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSFSHLog.java | JUnit5 tag migration for subclass test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSAsyncFSWAL.java | JUnit5 tag migration for subclass test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterStatusPublisher.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartSplitWithoutZk.java | JUnit5 tag migration for subclass test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailoverSplitWithoutZk.java | JUnit5 tag migration for subclass test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailover.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestart.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCloseAnOpeningRegion.java | JUnit5 lifecycle/tag migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java | JUnit5 tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClientMetaServiceRPCs.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestBalancer.java | JUnit5 lifecycle/tag migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerMetrics.java | JUnit5 lifecycle/tag migration; replaces TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAlwaysStandByHMaster.java | Migrates MiniCluster rule to JUnit5 MiniClusterExtension. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java | JUnit5 lifecycle/tag/assertion migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestRestartCluster.java | JUnit5 lifecycle migration for shared cluster restart base class. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java | JUnit5 lifecycle migration; replaces TestName with TestInfo-derived table names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
I have checked that the number of unit tests was consistent before and after, and that the unit tests were run in the same way, so let us merge it first! |
liuxiaocs7
added a commit
to liuxiaocs7/hbase
that referenced
this pull request
Apr 10, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org>
liuxiaocs7
added a commit
that referenced
this pull request
Apr 10, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.