[server] Add authorization to databaseExists and tableExists RPC call…#3078
Open
vaibhavk1992 wants to merge 1 commit intoapache:mainfrom
Open
[server] Add authorization to databaseExists and tableExists RPC call…#3078vaibhavk1992 wants to merge 1 commit intoapache:mainfrom
vaibhavk1992 wants to merge 1 commit intoapache:mainfrom
Conversation
apache#2007) Currently, the databaseExists and tableExists RPC methods do not enforce authorization, allowing any authenticated user to check if databases or tables exist, which poses a security risk. This commit adds authorization checks to both methods: - databaseExists: Checks DESCRIBE permission on the database - tableExists: Checks DESCRIBE permission on the table For security, both methods return false for unauthorized access, preventing information disclosure. Unauthorized users cannot distinguish between "resource doesn't exist" and "no permission", which prevents reconnaissance attacks to map database structure. Changes: - Modified RpcServiceBase.databaseExists() to catch authorization exceptions - Modified RpcServiceBase.tableExists() to catch authorization exceptions - Added testDatabaseExistsAuthorization() integration test - Added testTableExistsAuthorization() integration test Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the databaseExists and tableExists RPC methods do not enforce authorization, allowing any authenticated user to check if databases or tables exist, which poses a security risk.
This commit adds authorization checks to both methods:
For security, both methods return false for unauthorized access, preventing information disclosure. Unauthorized users cannot distinguish between "resource doesn't exist" and "no permission", which prevents reconnaissance attacks to map database structure.
Changes: