bench: add key-only payload sort benchmarks#21837
Open
gratus00 wants to merge 1 commit intoapache:mainfrom
Open
bench: add key-only payload sort benchmarks#21837gratus00 wants to merge 1 commit intoapache:mainfrom
gratus00 wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
@mbutrovich would really appreciate your review on this, I think there might be room for improvement here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially addresses #21543.
Rationale for this change
#21543 points out that the existing sort benchmark does not cover an important ExternalSorter shape: sorting by a cheap key while carrying non-key payload columns through the sort
The existing tuple/string/dictionary cases sort by every column via
make_sort_exprs(schema). That is useful coverage, but it does not model queries likeORDER BY keyover rows that also contain UTF-8 or dictionary payload columns. This PR adds benchmark coverage for that case, following the discussion in #21543 and the benchmark/use-case direction from #21688I used Codex to help draft parts of this benchmark change and the PR description. I reviewed and adjusted the resulting code locally before opening the PR
What changes are included in this PR?
1024to8192, matching DataFusion's default target batch size more closelyi64 key utf8 payloadi64 key dictionary payloadkeywhile carrying payload columnsThe new cases are run across the existing four benchmark shapes:
merge sortedsort mergesortsort partitionedAre these changes tested?
Focused checks run locally:
Are there any user-facing changes?
No. This is a benchmark-only change