Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 51 commits into
base: main
Choose a base branch
from

add test for pre/post migration

34b0729
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

add test for pre/post migration
34b0729
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 7, 2026 in 5m 0s

Quality Gate failed

Failed conditions
1 Security Hotspot
33.8% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 204 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0mNDXNmxdebns9DnLi&open=AZ0mNDXNmxdebns9DnLi&pullRequest=12617

Check warning on line 1267 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrK&open=AZz35YY_4256DVCsFLrK&pullRequest=12617

Check warning on line 49 in server/src/main/java/com/cloud/storage/ClvmLockManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_hostDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTXm331ZRqy8rtit&open=AZycJTXm331ZRqy8rtit&pullRequest=12617

Check failure on line 1298 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1EcZMYlli-YfopRUBQ&open=AZ1EcZMYlli-YfopRUBQ&pullRequest=12617

Check warning on line 370 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrY&open=AZz35YeN4256DVCsFLrY&pullRequest=12617

Check warning on line 7539 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "clustered" local variable. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1FdYz3oC2Lq8aFxznS&open=AZ1FdYz3oC2Lq8aFxznS&pullRequest=12617

Check failure on line 1289 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1EcZMYlli-YfopRUBP&open=AZ1EcZMYlli-YfopRUBP&pullRequest=12617

Check failure on line 1020 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1EcZMYlli-YfopRUBD&open=AZ1EcZMYlli-YfopRUBD&pullRequest=12617

Check warning on line 1519 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrO&open=AZz35YeN4256DVCsFLrO&pullRequest=12617

Check warning on line 96 in server/src/test/java/com/cloud/storage/ClvmLockManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "getClvmLockHostId"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pFL1oHBDapnzk6OhR&open=AZ1pFL1oHBDapnzk6OhR&pullRequest=12617

Check warning on line 492 in engine/storage/src/test/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelectorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testSelectObject_CLVMVolumeWithInvalidLockHostId" on line 476. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pFLWKHBDapnzk6Og6&open=AZ1pFLWKHBDapnzk6Og6&pullRequest=12617

Check warning on line 73 in engine/storage/src/test/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelectorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_storagePoolDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0xehRNDDwRlMHM1FEt&open=AZ0xehRNDDwRlMHM1FEt&pullRequest=12617

Check failure on line 333 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0mNDXNmxdebns9DnLu&open=AZ0mNDXNmxdebns9DnLu&pullRequest=12617

Check failure on line 371 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--noheadings" 8 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrQ&open=AZz35YeN4256DVCsFLrQ&pullRequest=12617

Check warning on line 2712 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "vm". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0sIVbYlpSFCu4-z-Dm&open=AZ0sIVbYlpSFCu4-z-Dm&pullRequest=12617

Check warning on line 431 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrZ&open=AZz35YeN4256DVCsFLrZ&pullRequest=12617

Check warning on line 420 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrL&open=AZz35YeN4256DVCsFLrL&pullRequest=12617

Check failure on line 1554 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--output=json" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrS&open=AZz35YeN4256DVCsFLrS&pullRequest=12617

Check warning on line 3402 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 89 to 64, Complexity from 22 to 14, Nesting Level from 4 to 2, Number of Variables from 27 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pFLx0HBDapnzk6OhI&open=AZ1pFLx0HBDapnzk6OhI&pullRequest=12617

Check warning on line 4902 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 170 to 64, Complexity from 47 to 14, Nesting Level from 4 to 2, Number of Variables from 31 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0sIVbYlpSFCu4-z-Dp&open=AZ0sIVbYlpSFCu4-z-Dp&pullRequest=12617

Check warning on line 176 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostMigrationCommandWrapperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.libvirt.LibvirtException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ1pcbw51MRvjmKtxodO&open=AZ1pcbw51MRvjmKtxodO&pullRequest=12617

Check warning on line 84 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZx43iV5jVPAID_RF5br&open=AZx43iV5jVPAID_RF5br&pullRequest=12617

Check warning on line 257 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testCLVMVolumePathFormat" on line 246. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0mNDXNmxdebns9DnLy&open=AZ0mNDXNmxdebns9DnLy&pullRequest=12617

Check warning on line 2549 in server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0sIVjxlpSFCu4-z-Dz&open=AZ0sIVjxlpSFCu4-z-Dz&pullRequest=12617

Check failure on line 301 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0mNDXNmxdebns9DnLr&open=AZ0mNDXNmxdebns9DnLr&pullRequest=12617
View more details on SonarQubeCloud