Add badge to monitor favicon when critical alerts exist#6396
Open
DomGarguilo wants to merge 1 commit into
Open
Add badge to monitor favicon when critical alerts exist#6396DomGarguilo wants to merge 1 commit into
DomGarguilo wants to merge 1 commit into
Conversation
Member
Author
|
Here are some other examples of badges: I just did a red dot in the top right for the first pass. If anyone has any suggestions or wants to see what other badges/orientations look like I will test them out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6389
This PR adds a small red circle badge to the favicon when critical alerts exist. It gets cleared when there are no critical alerts. It should be present at the same time that the global banner is shown (except this badge is also shown on the alerts page) (banner added in #6387)
Without badge:
With badge: