[codex] support proto3 custom option extensions#37
Conversation
Add shared classification for protobuf custom option extension declarations, including ExtensionRangeOptions. Validate proto3 extension declarations across descriptor graphs and keep unsupported extension fields out of codec generation. Refine descriptor-set discovery so pure option-definition files remain import metadata while mixed schema files are still generated. Track the new generator module in both source-tree and installed CMake package configs.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b31546cd91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Scope proto3 extension validation to the selected import closure so unrelated descriptor-set files cannot block generation. Teach descriptor-set discovery to skip transitive custom-option helper types and namespace-only nested extension containers while still selecting option files that expose public fields or nested messages. Add regression coverage for transitive helper enums, nested scalar option namespaces, public namespace guards, and unrelated invalid proto3 extensions outside the selected graph.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
ExtensionRangeOptions.Validation
uv run pytest -q --basetemp .pytest-tmp->203 passeduv run ruff check src tests-> passedgit diff --check-> no whitespace errors; only Git LF-to-CRLF warningsshare/protocyte/python/protocyte/extensions.pyexists, and configured an installedfind_package(protocyte CONFIG REQUIRED)descriptor-setDISCOVERconsumer successfully.