Skip to content

Fixed read_attribute for encrypted attributes #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshibuya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed read_attribute for encrypted attributes #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/lockbox/model.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ def _update_record(*)
super
end

def [](attr_name)
# also covers [], which reads through read_attribute
def read_attribute(attr_name, &block)
send(attr_name) if self.class.lockbox_attributes.any? { |_, la| la[:attribute] == attr_name.to_s }
super
end
Expand Down
16 changes: 16 additions & 0 deletions test/model_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,22 @@ def test_keyed_getter
assert_equal "test@example.org", user["email"]
end

def test_read_attribute
skip if mongoid?

user = User.create!(name: "Test", email: "test@example.org")
assert_equal "Test", user.read_attribute(:name)
assert_equal "Test", user.read_attribute("name")
assert_equal "test@example.org", user.read_attribute(:email)
assert_equal "test@example.org", user.read_attribute("email")

user = User.last
assert_equal "Test", user.read_attribute(:name)
assert_equal "Test", user.read_attribute("name")
assert_equal "test@example.org", user.read_attribute(:email)
assert_equal "test@example.org", user.read_attribute("email")
end

def test_keyed_setter
skip if mongoid?

Expand Down