Skip to content

feat(prs-556): wire deploy-time ABI trust posture into parser_app - #441

Closed
pepe-anchor wants to merge 2 commits into
prs-556-core-policyfrom
prs-556-parser-app
Closed

feat(prs-556): wire deploy-time ABI trust posture into parser_app#441
pepe-anchor wants to merge 2 commits into
prs-556-core-policyfrom
prs-556-parser-app

Conversation

@pepe-anchor

@pepe-anchor pepe-anchor commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Why am I making this PR?

Wire the MetadataTrustPolicy from PR #440 into parser_app so deployments express their posture via cmdline flags instead of inheriting an implicit default.

What am I changing?

Add --accept-unsigned-abis and --accept-signatures-from-pubkey flags to parser_app CLI. Mutually exclusive (clap forbids), at least one required at startup. Parse into ParserConfig.abi_trust and thread through create_registry to the converter.

What is the Linear ticket?

PRS-556

What are the rollback steps?

Redeploy with a manifest whose pivotArgs omit the new flags. The old parser_app binary ignores unknown flags.

Is this change backwards compatible?

No — parser_app now refuses to start without an explicit posture. Existing launch paths (Makefile, integration harness, CI) pass --accept-unsigned-abis explicitly.

Does this require cross-team/service coordination?

Yes — live deployments need a redeploy to pick up a posture.

How do I know it works as designed? Which tests exercise this code?

CLI arg parsing tests cover both/neither rejection. Registry test pins both postures reach the converter.

Wire the deploy-time policy through try_extract_from_chain_metadata.
Remove AbiExtraction wrapper; function now returns Option<AbiRegistry>.
@pepe-anchor

Copy link
Copy Markdown
Contributor Author

Closing in favour of a replacement with the correct base. GitHub refuses to retarget this PR ('Cannot change the base branch because the pull request is part of a stack'), and it needs to sit on prs-556-ethereum-converter rather than prs-556-core-policy: parser_app consumes abi_metadata::signer_allowlist_from_hex, which the eth-converter commit introduces. No comments or reviews here to lose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant