feat(prs-556): wire deploy-time ABI trust posture into parser_app - #441
Closed
pepe-anchor wants to merge 2 commits into
Closed
feat(prs-556): wire deploy-time ABI trust posture into parser_app#441pepe-anchor wants to merge 2 commits into
pepe-anchor wants to merge 2 commits into
Conversation
pepe-anchor
force-pushed
the
prs-556-parser-app
branch
from
August 6, 2026 13:30
0b26b19 to
d025eb1
Compare
Wire the deploy-time policy through try_extract_from_chain_metadata. Remove AbiExtraction wrapper; function now returns Option<AbiRegistry>.
pepe-anchor
force-pushed
the
prs-556-parser-app
branch
from
August 6, 2026 14:14
d025eb1 to
8e9870a
Compare
pepe-anchor
force-pushed
the
prs-556-parser-app
branch
from
August 6, 2026 17:03
8e9870a to
d0e9fa4
Compare
Contributor
Author
|
Closing in favour of a replacement with the correct base. GitHub refuses to retarget this PR ('Cannot change the base branch because the pull request is part of a stack'), and it needs to sit on prs-556-ethereum-converter rather than prs-556-core-policy: parser_app consumes |
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I making this PR?
Wire the MetadataTrustPolicy from PR #440 into parser_app so deployments express their posture via cmdline flags instead of inheriting an implicit default.
What am I changing?
Add
--accept-unsigned-abisand--accept-signatures-from-pubkeyflags to parser_app CLI. Mutually exclusive (clapforbids), at least one required at startup. Parse intoParserConfig.abi_trustand thread throughcreate_registryto the converter.What is the Linear ticket?
PRS-556
What are the rollback steps?
Redeploy with a manifest whose pivotArgs omit the new flags. The old parser_app binary ignores unknown flags.
Is this change backwards compatible?
No — parser_app now refuses to start without an explicit posture. Existing launch paths (Makefile, integration harness, CI) pass
--accept-unsigned-abisexplicitly.Does this require cross-team/service coordination?
Yes — live deployments need a redeploy to pick up a posture.
How do I know it works as designed? Which tests exercise this code?
CLI arg parsing tests cover both/neither rejection. Registry test pins both postures reach the converter.