Skip to content

Fix Signal v8.30.0 materialisation and preserve logging preferences - #31

Merged
purpleempress merged 1 commit into
mainfrom
fix/ci-signal-20261002
Oct 2, 2026
Merged

purpleempress merged 1 commit into
mainfrom
fix/ci-signal-20261002

Conversation

@purpleempress

Copy link
Copy Markdown
Member

Repair

  • Rebase the affected source commits and regenerate their patches against the Signal v8.30 preference migration, preserving compatibility with the published v8.29.1 pin.
  • Move Vesper logging preferences out of the removed upstream TextSecurePreferences class; retain the default shared-preferences file, pref_log_enabled key, disabled default, and Java/Kotlin callers.
  • Preserve upstream settings defaults and privacy implementation; re-anchor downstream theme, privacy and configuration hunks without restoring removed upstream APIs.
  • Add offline regression fixtures and Robolectric coverage for existing logging preferences. Test the pinned release and v8.30.0 in the existing unsigned PR matrix.

Local verification

  • Reproduced the original materialisation failure and both new fixture failures before repair.
  • 41 exporter tests, 2 new regression fixtures, the existing conversation fixture, and 7 materialised source contracts passed.
  • Fresh full materialisation passed on v8.29.1 and v8.30.0; candidate tree matches the repaired source exactly.
  • actionlint, shell/Python syntax checks and git diff --check passed.

Full release builds and selected Android unit tests are running in PR CI. upstream.pin is unchanged. No production dispatch, publication, merge or issue closure is requested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T06:48:27.814687Z 80c221a PR opened
🔒 Security Review ✅ Completed 2026-10-02T06:50:28.668819Z 80c221a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@purpleempress

Copy link
Copy Markdown
Member Author

Verified at head 80c221a: PR CI run 36975143732 completed successfully on both pinned Signal v8.29.1 and v8.30.0. Both jobs completed full materialisation, source contracts, selected Android/Robolectric tests (including VesperLogPreferencesTest), release APK assembly, and unsigned universal APK upload. Both artifacts are present.

Local validation: 41 exporter tests, 2 new regression fixtures (confirmed failing before repair), 1 conversation fixture, and 7 source contracts per materialised version passed. The freshly materialised candidate tree equals the repaired source tree (0a6569f8e2f3efd75299e13f2add8496d070b34c); exporting it again leaves the repository unchanged. actionlint, shell/Python syntax checks and whitespace checks passed.

The only annotations are the same upstream Java deprecation warning in PushDecryptMessageJobEnvelopeMigration.java:14 on both versions. No blocking failures. Published pin remains v8.29.1. This PR is unmerged; no production workflow was dispatched and no issues were closed.

@purpleempress
purpleempress merged commit 4972387 into main Oct 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant