Repository navigation
Fix Signal v8.30.0 materialisation and preserve logging preferences - #31
Conversation
Signed-off-by: amber <amber@flourish.ch>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Verified at head 80c221a: PR CI run 36975143732 completed successfully on both pinned Signal v8.29.1 and v8.30.0. Both jobs completed full materialisation, source contracts, selected Android/Robolectric tests (including VesperLogPreferencesTest), release APK assembly, and unsigned universal APK upload. Both artifacts are present. Local validation: 41 exporter tests, 2 new regression fixtures (confirmed failing before repair), 1 conversation fixture, and 7 source contracts per materialised version passed. The freshly materialised candidate tree equals the repaired source tree ( The only annotations are the same upstream Java deprecation warning in PushDecryptMessageJobEnvelopeMigration.java:14 on both versions. No blocking failures. Published pin remains v8.29.1. This PR is unmerged; no production workflow was dispatched and no issues were closed. |
Repair
Local verification
Full release builds and selected Android unit tests are running in PR CI. upstream.pin is unchanged. No production dispatch, publication, merge or issue closure is requested.