Conversation
…loads The `app_instance.created` / `app_instance.status_changed` payloads only carried `app_instance_id`, Polydock's internal auto-increment id. Consumers never see that id: the API returns `uuid` when an instance is created, and `uuid` is the route key for the instance endpoints. So a receiver holding a uuid had no way to resolve an incoming webhook back to the instance it had provisioned. Add `app_instance_uuid` alongside the existing id, pin the identifying payload fields in a test, and document the app instance payload shape in docs/WEBHOOKS.md. Purely additive — no existing field changes, so current consumers are unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…l sets, CI gate (#256)
…l and pin it with a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this release:
bd04a24 fix(webhooks): close inter-chunk null-uuid window with atomic backfill and pin it with a test
d3e67fb fix(webhooks): backfill legacy null instance uuids and correct sensitive-data docs
2fad2c9 feat(webhooks): include app_instance_uuid in app instance webhook payloads
c4e7490 chore: import queueable trait and skip generated bootstrap cache in rector
77d2848 chore: enforce rector in ci and drop redundant phpcs
9c6be9f chore: apply rector laravel 13 level set
e77731c chore: apply rector type-declaration set and raise type-coverage floors
eca4ff6 chore: apply rector early-return set
7d98cf3 chore: apply rector code-quality set
3bd4806 chore: apply rector dead-code set
b45851e chore: apply rector php 8.4 level set
05170ce chore: raise phpstan to max with strict-rules and type-coverage ratchet floors
3357965 chore: include lagoon lifecycle script fields in store app activity log
118ea5f chore: do not write generated seed deploy key into the source tree
d059c27 chore: generate a valid throwaway deploy key when seed fixture is absent
07f10fa chore: seeders use local fixture deploy key instead of removed config
b247a9e chore: remove dead SSH key env vars and fallback code