feat: adding arm packaging and runtime support (ubuntu 24.04)#88
Open
ursuciprian wants to merge 1 commit into
Open
feat: adding arm packaging and runtime support (ubuntu 24.04)#88ursuciprian wants to merge 1 commit into
ursuciprian wants to merge 1 commit into
Conversation
bvolpato
reviewed
Jul 12, 2026
bvolpato
left a comment
Contributor
There was a problem hiding this comment.
PR currently conflicts with main and needs rebase before review can converge.
Blocking packaging issues:
- ARM artifacts referenced by README.md and PKGBUILD.template are never produced. release-linux.yml still runs one x86_64 job and uses x86_64 appimagetool, so ARM deb/tarball/AppImage URLs will not exist.
- PKGBUILD.template renamed checksum tokens, but aur-publish.yml still replaces only @@sha256@@. Generated PKGBUILD retains both new placeholders and breaks existing x86_64 AUR publishing.
- LIMUX_ARCH changes labels and package metadata without changing Zig/Cargo targets or target output paths. It can package native x86_64 binaries as arm64 artifacts.
nonblocking: WEBKIT_DISABLE_DMABUF_RENDERER and WEBKIT_WEBGL_DISABLE_GBM now default on for every GPU and architecture. Scope fallback to affected systems or avoid making degraded rendering universal.
Architecture mapping, unsupported-architecture rejection, GLAD whole-archive linking, and icon lookup changes otherwise look reasonable.
Recommendation: rebase onto current main, add real ARM release production and checksum wiring, and make architecture override build selected target or remove it.
(Review assisted by gpt-5.6-sol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.deb, tarball, AppImage naming, and ArchPKGBUILDlibghosttyGLAD static linking so ARM release builds resolve Ghostty GL loader symbolsUbuntu 24.04 ships
blueprint-compiler 0.12.0, but Ghostty packaging requires>= 0.16.0. For local ARM packaging validation, I used a local venv withblueprint-compiler==0.20.4ahead of/usr/binonPATH.