Skip to content

Use shared layout for worldwide_corporate_information_about_page views - #5749

Merged
AshGDS merged 1 commit into
mainfrom
PNP-10129
Sep 9, 2026
Merged

AshGDS merged 1 commit into
mainfrom
PNP-10129

Conversation

@AshGDS

@AshGDS AshGDS commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What/ Why

Visual changes

Before After
image image

@govuk-ci
govuk-ci temporarily deployed to govuk-frontend-app-pr-5749 August 21, 2026 14:03 Inactive
@govuk-ci
govuk-ci temporarily deployed to govuk-frontend-app-pr-5749 August 21, 2026 14:50 Inactive
@AshGDS AshGDS self-assigned this Sep 1, 2026
@AshGDS
AshGDS requested a review from andysellick September 1, 2026 11:12
@AshGDS
AshGDS marked this pull request as ready for review September 1, 2026 11:12
Comment thread app/views/worldwide_corporate_information_page/show.html.erb
Comment thread app/controllers/worldwide_corporate_information_page_controller.rb Outdated
end %>
</div>
</article>
</article>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: I note that this page already used the article tag. I think this is the first time I've noticed it in a page during this piece of work, so we should maybe have a broader conversation about the use of article in page types, as if it's appropriate we should use it everywhere to be consistent.

Comment thread app/views/worldwide_corporate_information_page/show.html.erb Outdated
Comment thread app/views/worldwide_organisation/_header.html.erb Outdated
@govuk-ci
govuk-ci temporarily deployed to govuk-frontend-app-pr-5749 September 8, 2026 13:39 Inactive
@AshGDS

AshGDS commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

@andysellick Should be ready for another review 👍

@andysellick andysellick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this is the last use of some of the worldwide partials - want to pair on cleaning them up?

@AshGDS

AshGDS commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @andysellick, sounds good 👍

@AshGDS
AshGDS merged commit 4a2495f into main Sep 9, 2026
13 checks passed
@AshGDS
AshGDS deleted the PNP-10129 branch September 9, 2026 09:19

This branch was previously deployed

1 inactive deployment
govuk-frontend-app-pr-5749 — 156e0bae Deployed Sep 8, 2026 by govuk-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants