Repository navigation
Conversation
giunatale
requested review from
clockworkgr,
julienrbrt and
tbruyelle
as code owners
October 22, 2026 10:31
julienrbrt
approved these changes
Oct 22, 2026
giunatale
force-pushed
the
giunatale/chore/lint-root-tests
branch
from
October 27, 2026 12:19
aaa73bc to
ff679e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.golangci.ymlno longer leaves the root module's test files out, the last gap after #81 brought the e2e and app modules under lint;make lintnow covers every Go file in the repo that is not generated.The first run found 114 findings in 38 files, all fixed here. Most are mechanical: 42 redundant conversions, import grouping in 37 files, 16 test helpers missing
t.Helper(), two deprecated context wrappers. The rest are small but real: three unchecked error returns in the consumer genesis tests, now asserted; one assignment nothing read; and eight repeated literals now named once per package (the live and the fixture provider client ids on the consumer side, the client id, pool denom and chain id on the provider side, the event attribute key from the types package, and the already-declared owner constant reused). Two helpers that every scenario calls with the same value keep their parameter under a statednolint, to stay generic.The Makefile and
AGENTS.mdnotes about what lint covers follow.