fix(db): persist delete-only writing segment records#618
Open
egolearner wants to merge 1 commit into
Open
Conversation
A writing segment can contain delete WAL records while its document count remains zero. Schema changes previously skipped the switch in this state and could destroy the WAL before the delete snapshot was persisted, causing recovery failures or deleted documents to reappear. Add Segment::has_record to account for both documents and WAL records, use it for schema and optimize switch decisions, and make the delete-only switch path flush without creating an empty persisted segment. Add a reopen regression test for the column DDL path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A writing segment can contain delete WAL records while its document count remains zero. Schema and index changes previously used the document count to decide whether to switch the writing segment, so a delete-only WAL could be destroyed before its delete snapshot was persisted. This could make collection recovery fail or allow deleted documents to reappear.
Fix
Tests