docs(assurance): correct API key storage claims - #1449
Draft
Frank-zhu0404 wants to merge 1 commit into
Draft
Frank-zhu0404 wants to merge 1 commit into
Frank-zhu0404 wants to merge 1 commit into
Conversation
ASSURANCE_CASE.md said keys are env-only and never stored in config files. The CLI persists api_key/auth_token to ~/.opencodereview/config.json with mode 0600. Align the assurance case with that behavior. Fixes alibaba#1440
Contributor
|
✅ OpenCodeReview: Review skipped: no items were selected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ASSURANCE_CASE.mdclaimed API keys are env-only and never stored in config files. The CLI actually persistsapi_key/auth_tokento~/.opencodereview/config.jsonwith mode0600(saveConfigincmd/opencodereview/provider_cmd.go).This PR aligns the assurance case with real credential sources:
OCR_LLM_TOKEN, provider-specific vars)api_key_cmd/auth_token_cmd)0600)Also updates Threat T2, Fail-safe defaults, Separation of privilege, and OWASP A07 rows to match.
Type of Change
How Has This Been Tested?
Docs-only change. Verified claims against
saveConfig/ config path behavior and grepped that no other mirrored "env-only / never in config" assurance statements remain inASSURANCE_CASE.md. Rango run scripts/verify-english-only.go(pass).make testpasses locallyCross-checked threat table + Saltzer/Schroeder + OWASP A07 wording against CLI config persistence (
0600) and masking onocr config setdisplay.Checklist
go fmt,go vet)AI disclosure: assisted by Grokbuild (Grok 4.6) for drafting the ASSURANCE_CASE wording; human-reviewed every line against CLI config persistence behavior. Codex (gpt-5.6-sol) used for read-only review only (VERDICT=PASS). No AI commit trailers.
Related Issues
closes #1440