Repository navigation
Conversation
xiehuanyi
force-pushed
the
fix/voluptuous-zero-max
branch
from
October 10, 2026 11:30
d6928bc to
bc32bb5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SomeOf(validators=[int, str], max_valid=0)currently accepts integers and strings: the explicit zero is replaced with the number of validators. This prevents expressing that no sub-validator may pass.Default
min_validandmax_validonly when they areNone, preserving explicit zero bounds. Add regression coverage for direct calls and Schema-wrapped validation, including a zero minimum and maximum together.Validation: both new direct-call regressions fail on unchanged master; the complete test suite passes after the fix (184 tests). Flake8 with doctests and Black checks pass.