Repository navigation
feat: add JSON Schema export functionality - #532
Open
doubledare704 wants to merge 6 commits into
Open
doubledare704 wants to merge 6 commits into
doubledare704 wants to merge 6 commits into
Conversation
doubledare704
force-pushed
the
feature/json-schema-export
branch
from
August 31, 2025 08:48
efd7df1 to
d8092eb
Compare
Owner
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8092eb81d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add comprehensive JSON Schema export capability to voluptuous schemas, addressing issue alecthomas#408. This enables integration with modern IDEs, API documentation tools, and other validation systems. Features: - Convert voluptuous schemas to JSON Schema format - Support for all major validators (Range, Length, Email, URL, etc.) - Handle composite validators (All, Any, ExactSequence) - Proper Required/Optional marker conversion - Nested object and array schema support - Default value handling with JSON serialization safety API: - Schema.to_json_schema() method on Schema instances - to_json_schema() standalone function - Full backward compatibility maintained Testing: - Comprehensive test suite with 100% coverage - Real-world example scenarios - Edge case handling - JSON serialization validation Documentation: - Updated README with usage examples - Complete example script demonstrating features - Inline documentation and docstrings Closes alecthomas#408
- Replace bare except clause with specific exception types - Fix all 17 mypy type checking errors: * Add proper type annotations for Dict[str, Any] * Replace callable with typing.Callable * Fix incompatible type assignments * Resolve indexing operation type issues * Add type safety for validator method parameters - Remove unused import (voluptuous.validators) - Maintain full backward compatibility and functionality All flake8 and mypy checks now pass with zero issues. All 162 existing tests continue to pass.
doubledare704
force-pushed
the
feature/json-schema-export
branch
from
August 25, 2026 21:00
d8092eb to
abe2173
Compare
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c90620865
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive JSON Schema export capability to voluptuous schemas, addressing issue #408. This enables integration with modern IDEs, API documentation tools, and other validation systems.
Features:
API:
Testing:
Documentation:
Closes #408